search

Fintasys / emoji_picker_flutter

A Flutter package that provides an Emoji picker widget with 1500+ emojis in 8 categories.
MIT License
154 stars 114 forks source link

revert kotlin version back to 1.7.10 #191

Closed mtallenca closed 3 months ago

mtallenca commented 3 months ago

kotlin version 1.9.22 compiles code with Java 17 and we're getting java 8 / 17 warnings from gradle 7. Those warnings are errors in gradle 8.

Latest stable flutter and it's packages are using 1.7.10.

Fintasys commented 3 months ago

I provided already a branch with the downgrade here. But so far I haven't heard from anyone that it fixes the issue https://github.com/Fintasys/emoji_picker_flutter/issues/189#issuecomment-1972748095

mtallenca commented 3 months ago

Last week we moved our project to 1.9.22 so get emoji_picker_flutter to compile our production app that uses 100+ packages with 600k android installs. Moving to 1.9.22, Gradle 7 produced warnings of mixing old java with java 17 (used by 1.9.22). Fyi these warnings are defaulted to errors in Gradle 8.

Our user perceived crash rate had been in the normal range of 0.15%. Updating our user base to the 1.9.22 build the crash rate began climbing, hit 6% within 2 days. 99.9% of the crashes were in android library code when resuming the app from background.

Crash rate did not change with the our 500k iOS users. So we looked at android specific changes between releases.

We created a fork of emoji_picker_flutter setting kotlin to 1.7.10 and reverted our project back to 1.7.10. The java old/new mix warnings go away. We released this version of the app 2 days ago and crash rate has been restored to sub 0.15%.

On Tue, Mar 5, 2024, 2:18 AM Stefan Humm @.***> wrote:

I provided already a branch with the downgrade here. But so far I haven't heard from anyone that it fixes the issue

189 (comment)

https://github.com/Fintasys/emoji_picker_flutter/issues/189#issuecomment-1972748095

— Reply to this email directly, view it on GitHub https://github.com/Fintasys/emoji_picker_flutter/pull/191#issuecomment-1978416555, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXMGLNVKBCK3N7ETOEWOKDYWWLXDAVCNFSM6AAAAABEFVVBECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZYGQYTMNJVGU . You are receiving this because you authored the thread.Message ID: @.***>

AndriiChuzhynov commented 3 months ago

It works in my case. But I still don't know the root cause why it's broken in my project and I can't reproduce with fresh project 🤷‍♂️

Fintasys commented 3 months ago

This pull request (https://github.com/Fintasys/emoji_picker_flutter/pull/192) appears to offer a more sustainable solution for the future. Let's try implementing it before deciding whether to revert to the Kotlin version.

JohnGalt1717 commented 3 months ago

This still doesn't work. It forces me to update kotlin which then blows up the entire rest of the flutter toolchain for Android.

You're pushing people into a non-standard environment that isn't the default.

Fintasys commented 3 months ago

@JohnGalt1717 have you tried the most recent release? If it doesn't work, please file another issue 🙏