search

FireflyArtsCollective / ffagc

Firefly Art Grant Core Website
3 stars 2 forks source link

fix tests broken because max_funding_dollars has been removed #123

Closed ywwg closed 5 years ago

ywwg commented 5 years ago

I changed the db schema and forgot to update the tests. Before we had a single integer, "max_funding_dollars" to represent how much an artist could ask for in funding. Now we have a (hacky) string that is a comma-separated list of values, like: 1,50-99,500,1000. All the tests that expect max_funding_dollars need to be fixed to work with this string instead. In some cases just removing the max_funding part will work, in others the test will need to be tweaked depending on what it's testing

ywwg commented 5 years ago

This turned out to be super difficult, sorry! Fixed in 7b48c0d0e40b902e9054498b5487e6f9a661ed1d