Open gagantrivedi opened 1 year ago
@kyle-ssg this needs a small amount of FE work to expose the use_mv_v2_evaluation
flag in the environment settings. We'll need to add some description around what it does to ensure people understand. The description should be something like:
Enabling this setting will ensure that multivariate evaluations made by the API are consistent with those made by local evaluation mode in our server side SDKs.
Warning: toggling this setting will mean that some users will start receiving different multivariate values via the API / remote evaluation for any existing multivariate features that you have. Values received in local evaluation mode will not change.
@dabeeeenster happy with that description / warning?
This was marked as closed, though the feature flag it's associated with is disabled in production (mv_v2_setting), not sure if this is ready to enable based on the issue description
@gagantrivedi can you confirm here?
Yeah, we can enable it - it is done for edge and core PS: I think node still needs to implement this behaviour
PS: I think node still needs to implement this behaviour
I don't think this is true since it currently uses: identityModel.djangoID || identityModel.compositeKey
. Since the NodeJS SDK will never receive an identity that has a DjangoID, it will always use the compositeKey which is the desired behaviour.
@gagantrivedi can you confirm that Go and Edge Proxy were done? They are not marked off in the list above.
This should be identical across all the SDKs. Needs to be implemented for:
In order to avoid rolling v2 API's, For core, we will create a flag on environment named
use_mv_v2_evaluation
when turned on will usecomposite key
elseidentifier if dynamodb_enabled else (id or uuid))
, Edge will use that as flag as well to usecomposite_key
if enabled instead of identifier. Release the Major version for Golang to use composite key.gz#372