search

FleexSecurity / fleex

Fleex makes it easy to create multiple VPS on cloud providers and use them to distribute workloads.
https://fleexsecurity.github.io/fleex-docs/
Apache License 2.0
250 stars 30 forks source link

Replace path by filepath #1

Closed melardev closed 3 years ago

melardev commented 3 years ago

Hi, "path" uses "/" as path separator regardless of the platform where we are compiling which may have undesired effects, better use "filepath" which is cross-platform. I tweeted once about an app that "stopped" working on Windows, the reason was exactly that.

https://twitter.com/melardev/status/1327761725664489472

Someone also blogged about it: https://parsiya.net/blog/2019-03-09-path.join-considered-harmful/

xm1k3 commented 3 years ago

Hi @melardev, thank you for opening a pull request on this, we have seen your commit and we really appreciate your showing us this tip for cross-platform filepath management. Feel free to give us fleex feedback at any time.

Best regards, xm1k3