Added conversation view in inbox and message screen

FlowCrypt / flowcrypt-android

FlowCrypt Android App

https://flowcrypt.com

Other

93 stars 11 forks source link

Added conversation view in inbox and message screen #2821

Open DenBond7 opened 4 months ago

DenBond7 commented 4 months ago

This PR Added a conversation view in the inbox and message screen

close #74

Tests (delete all except exactly one):

Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

[ ] addresses the issue it closes (if any)
[ ] code is readable and understandable
[ ] is accompanied with tests, or tests are not needed
[ ] is free of vulnerabilities

DenBond7 commented 2 days ago

@sosnovsky Basically, this functionality is ready for checking. Please look at the new version of the conversation view. Please test the following: thread details, thread lists, drafts, and replies. I need to hear some feedback about these changes. I've tried to migrate all functionality from the previous version to allow users to use old functionality.

Unfortunately, it will be a big PR with many changes.

@martgil Please look at this PR too as a tester. Maybe you will find some bugs that I missed )).

While you are checking this PR I will work on new tests.

sosnovsky commented 2 days ago

Hi @DenBond7, I'll test it today or tomorrow, will let you know if I'll notice any issues or possible improvements.

martgil commented 2 days ago

Hello @DenBond7, Will do. I’ll let you know immediately if I come across any interesting findings.

martgil commented 1 day ago

Hello @DenBond7 - Here are the things I've noticed when checking this new feature. The added feature for the conversation view is truly remarkable and UX improved alot.

For reply that is sent as reply all in FlowCrypt browser extension marked as "Fwd".

Scenario: user 2 sends an email to user1,3 is in "To" field. user 1 responded in reply all.

In the FlowCrypt android app, the email is marked "Fwd" where it should be fine to be label as "Re: " but got "Fwd: Re: test"

sosnovsky commented 1 day ago

Hello @DenBond7, great job on thread support implementation, it's much more convenient to read long threads now 👍

Just noticed a few things:

currently in threads messages are sorted from newest to the oldest, while it's more common in email clients to show old emails on the top and newest in the bottom. and when opening thread it should scroll to the first unread message, like in gmail app
as for me, there is no need to show the preview is not available for messages with PGP label for PGP messages, it'll be better to show just one line of encrypted content
in long threads older messages become too narrow when quoted, as each message has additional tab in the beginning, leading to such big indents: