Closed akaptano closed 2 years ago
Hi Alan,
1) I checked all files for missing docstrings and added them where necessary. Sometimes the docstrings of non-private member functions in derived classes are left blank on purpose because, in the Sphinx documentation, the docstring is inherited from the base class if it is not overwritten in the derived class (pretty cool feature of Sphinx).
2)
1) The development of flowtorch is an ongoing process. For the next release, I already have functionality for outlier detection and a robust SVD/DMD variant plus examples in the pipeline. Also, if you look at the class structure of ROM
and Encoder
, you will find that idea is to add more derived classes of each in the feature such that one can combine all available encoders with all available ROMs (currently, there is only one of each, so the intension is probably not perfectly clear yet).
2) It is indeed possible to use flowtorch in conjunction with existing packages specialized in doing only a single step in the analysis and modeling pipeline. I've been doing that as a matter of fact myself with PyDMD. This possibility is now mentioned in the README, and I also added links to two existing complementary packages.
Feel free to close this issue if you are happy with my answers. Many thanks again for your suggestions!
Andre
Okay I am done with my review. I will finalize it on the review GitHub page when we resolve the issues I submitted. The code and code documentation looks excellent. Good use of comments and class inheritance. Last optional comments about minor code functionality and documentation: