Add/remove custom controls dynamically

paodb commented 2 months ago

~~This depends on the merge of https://github.com/FlowingCode/google-map/pull/35 and the release of the new version of the web-component.~~

This PR adds the possibility to add and remove custom controls dynamically. Also adds a method to remove all existing custom controls. Web component version was updated to 3.8.0.

Summary by CodeRabbit

Release Notes

New Features
- Introduced a demo application showcasing custom controls for Google Maps, allowing dynamic addition and removal of controls.
- Added a new CSS file for styling custom control buttons.
Enhancements
- Updated the Google Maps addon version to improve functionality and performance.
- Enhanced management of custom controls within the Google Map component, including new methods for adding and removing controls.
Bug Fixes
- Resolved issues related to the handling of custom controls in the Google Map component.

coderabbitai[bot] commented 2 months ago

Walkthrough

The pull request introduces updates to the Google Maps Addon for the Vaadin platform, focusing on version increments and enhancements to custom control management within the GoogleMap class. The NPM package version has been updated from 3.7.1 to 3.8.0 across multiple classes. A new demo application showcasing custom controls has been added, along with corresponding styling rules.

Changes

File	Change Summary
`pom.xml`	Updated `google-maps` version from `2.1.1-SNAPSHOT` to `2.2.0-SNAPSHOT`.
`src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMap.java`	Updated `@NpmPackage` version from `3.7.1` to `3.8.0`, added methods for managing custom controls.
`src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapMarker.java`	Updated `@NpmPackage` version from `3.7.1` to `3.8.0`.
`src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapPoint.java`	Updated `@NpmPackage` version from `3.7.1` to `3.8.0`.
`src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapPoly.java`	Updated `@NpmPackage` version from `3.7.1` to `3.8.0`.
`src/test/java/com/flowingcode/vaadin/addons/googlemaps/CustomControlsDemo.java`	Added a new demo application for Google Maps with custom controls.
`src/test/java/com/flowingcode/vaadin/addons/googlemaps/GooglemapsDemoView.java`	Added `CustomControlsDemo` to the demo view.
`src/test/resources/META-INF/resources/frontend/styles/google-maps/custom-controls-demo-styles.css`	Added new CSS file for custom control button styling.

Possibly related PRs

137: The changes in this PR involve updates to the GoogleMap class, specifically adding a method for styling map features, which is related to the version updates in the main PR that enhance the Google Maps Addon functionality.

🐰 In the meadow where the maps do play,
A bunny hops with joy today.
Custom controls are here to stay,
With styles so bright, they'll lead the way!
Version updates, oh what a cheer,
Google Maps shines, let’s all draw near! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

javier-godoy commented 2 months ago

@paodb https://github.com/FlowingCode/google-map/pull/35 has been merged.

paodb commented 2 months ago

@coderabbitai review

coderabbitai[bot] commented 2 months ago

:white_check_mark: Actions performed

Review triggered. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.