FlowingCode / GridHelpers

Several grid recipes for Vaadin 23+ (and 22), ready to use. DOES NOT require extending Grid.
https://addonsv23.flowingcode.com/grid-helpers
Apache License 2.0
12 stars 1 forks source link

fix: #109 #110

Closed deyaeddin closed 8 months ago

sonarcloud[bot] commented 8 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

javier-godoy commented 8 months ago

LazyDataView.getItems().toList() is an expensive operation, because it retrieves the full data available to the component. If lazy data providers are being used, I think that https://github.com/vaadin-component-factory/selection-grid-flow provides a better approach.

javier-godoy commented 8 months ago

As explained above, this approach will have performance issues if the backend query returns a lot of items. Implementing support for lazy data providers requires that the client side provides the row indexes.