Fluorohydride / ygopro

A script engine for "yu-gi-oh!" and sample gui
GNU General Public License v2.0
1.85k stars 597 forks source link

use safe filename in Replay::SaveReplay #2569

Closed salix5 closed 4 months ago

salix5 commented 4 months ago

Save the replay with filename 1*2*3

Before: The replay file is not created.

After: The replay file is created with filename 1_2_3.yrp.

@mercury233 @purerosefallen

purerosefallen commented 4 months ago

is it a security thing?

salix5 commented 4 months ago

I think no.

Current version: If the input is an invalid filename, the replay file will not be stored.

salix5 commented 4 months ago

merge conflict temporarily closed