search

Fmstrat / diy-ipmi

A DIY IPMI / IP KVM system utilizing the Raspberry Pi
901 stars 98 forks source link

Updated for Debian 9 with PHP 7 #4

Closed sammcj closed 6 years ago

sammcj commented 6 years ago
Fmstrat commented 6 years ago

Thanks @sammcj . May I ask what unit tests you ran with this? Did you re-run the install script on a base install to ensure things function properly?

sammcj commented 6 years ago

In all honesty: no automated testing was performed as I did not use your bootstrapping script, regardless it would have failed as PHP 5.x is not available any long (nor should it be!) and simply replacing it with the PHP metapackage allows the supported PHP version (now 7.x) in Raspbian to be installed.

What I did test is running each command from your readme (and thus your script) line by line on a fresh install of Raspbian on a brand new stock standard raspberry pi zero w.

As mentioned in an issue I created I do not believe there is any need for an additional full raspberrypi for the functionality, regardless the PHP package version update still remains as a requirement.

Fmstrat commented 6 years ago

Sounds great. I'll merge this, create a release, and also create a dev branch for future PRs so it's easier to contribute. Thanks!