Windows 10 and 11 version "forgets" CPU WU after system restart

muziqaz commented 6 days ago

I thought it would be better to create a separate issue regarding the WU stuff. So every time I restart my Windows PCs, both systems FAH client downloads new WU instead of continuing with the old one, which was downloaded and being folded before the restart. On one system I can see 5 WU folders in Work directory, while I am only folding one at the moment. Log is not showing anything suspicious, except some subprocess error 14:20:09:E :Subprocess deallocated while process is still running Here is the log. log.txt

There has been no alterations to both systems in regards to boot/restart sequence. Everything is default as father Microsoft intended.

Linux system seems to work as intended

I mentioned this issue before in this comment and thread: https://github.com/FoldingAtHome/fah-client-bastet/issues/286#issuecomment-2368484970

kbernhagen commented 5 days ago

Does the forgetting not happen if you quit the client via sys tray before restarting the system?

muziqaz commented 5 days ago

Does the forgetting not happen if you quit the client via sys tray before restarting the system?

Quitting and then restarting resumes from where it stopped.

kbernhagen commented 5 days ago

My thought, which has been disputed in the past, is that Windows unceremoniously kills the client when there is a reboot, leaving database locked with unsaved changes.

The client is also running a native Win event loop. Maybe it just needs to catch appropriate messages for logout/shutdown.

muziqaz commented 5 days ago

I have a suspicion, too, that windows shutdown procedures are killing FAH processes, however, these systems had no issues with v7, as well as v7 would survive crashing system most of the time. I think v8 needs a bit more robust progress saving system. I'm not sure how v8 reacts to crahsing systems, since mine have been stable for quite some time now.

muziqaz commented 5 days ago

Also, what is weird, that V8 is downloading new WU, instead of resetting currently running one to zero. V7 sometimes used to lose WU's progress if system crash was severe. It had never lost a WU. Well there were several very rare occasions when another WU would get downloaded while old one was still there, but it would be visible in fahcontrol, and once newly downloaded WU was completed fahclient would pick up the old one and continue from where it left off. It would be great that I could still complete those other 4 WUs sitting on my SSD with v8

jcoffland commented 4 days ago

Could this be the same permissions issue that is causing the client not to restart. If the old WUs file permissions were changed such that it was inaccessible then it would not run after reboot. In this case, I would expect the old WU files to still be on the disk.

jcoffland commented 4 days ago

The permissions problem could be caused by either the client trying to start in the wrong directory, the file permissions on log.txt or it's directory are actually being changed or the client is starting under the wrong user.