FontoXML / fontoxpath

A minimalistic XPath 3.1 implementation in pure JavaScript
MIT License
135 stars 17 forks source link

Fix tokenize with capture groups #638

Closed DrRataplan closed 6 months ago

DrRataplan commented 6 months ago

Fixes a few tests as well!

Also fixes #635. Thanks @rrthomas for finding it!

DrRataplan commented 6 months ago

@devatwork could you help me out here? It seems like my push access to the repo is revoked. Didn't we end up at me retaining maintainer rights?

bundlemon[bot] commented 6 months ago

BundleMon

Files updated (2) Status | Path | Size | Limits :------------: | ------------ | :------------: | :------------: :white_check_mark: | fontoxpath.js
| 78.11KB (+42B +0.05%) | - :white_check_mark: | fontoxpath.esm.js
| 78.22KB (+38B +0.05%) | -

Total files change +80B +0.05%

Final result: :white_check_mark:

View report in BundleMon website ➡️


Current branch size history | Target branch size history

coveralls commented 6 months ago

Coverage Status

coverage: 91.599% (+0.005%) from 91.594% when pulling 148ea10e2551bf411b76c0254d4673bc652807ce on DrRataplan:regex-fix into 93d53ccccbe698477be6b6445c801562b89ac041 on FontoXML:master.

devatwork commented 6 months ago

@Erikvl87 Can you advice?

Erikvl87 commented 6 months ago

@DrRataplan Could you try to add at least 1 reviewer and get approval before merging?

DrRataplan commented 6 months ago

I am unable to add reviewers. @bwrrp could you review this somewhere this week? No hurry.

Erikvl87 commented 6 months ago

@DrRataplan, the individual Maintain permission granted to you was inadvertently revoked during your removal from the FontoXML organization. You have been re-assigned the Maintain role, which should resolve the issue of not being able to add the required reviewers.

DrRataplan commented 6 months ago

It works. Thanks!