Closed FireBurn closed 6 years ago
I'm not sure my take on OPENAM-8643 fixes the issue
OPENAM-7583 has been the most awkward one so far, finally got it compiling and running a simple instance
OPENAM-7958 looks good too
OPENAM-8106 looks good.
OPENAM-6562 and OPENAM-4743 looks good.
OPENAM-8321 and OPENAM-8248 look good too.
OPENAM-8951 and OPENAM-9216 are good too.
I'll see about fixing OPENAM-6373 tomorrow and also porting OPENAM-8117 too
Any idea about OPENAM-7125, OPENAM-5659 & OPENAM-9479 - they don't have any patches in the master branch and I can't view them in Jira either
OPENAM-8258 looks good
I think I've fixed up OPENAM-6373, added in the line and the extra bits required to make it work
I don't think there was anything wrong with OPENAM-7063 and I've slotted in OPENAM-8117 after it
Lastly I removed the extra import from OPENAM-7938
I think I fixed up OPENAM-8643, it's compiling now at least
I've also tested changing the password for the amAdmin user, but this was only on a one node cell
This review is getting a bit unmanageable, can we divide this up to smaller PRs?
To implement OPENAM-7362 I had to convert getAllServerIDs to be a Collection
Everything compiled OK, but I'm not sure if this will affect where it's used else where
If I close this PR, create a new one with the ones you've already OK'd then create seperate pull requests for each OPENAM fix?
That's one way to go about it, but I fear some of these fixes may have dependencies inbetween. I'm happy to review 3-4 commits at a time in quick succession if that helps.
Let me know, how you'd like things split up, and I'll get it sorted
I'm on IRC too if you'd like to talk about anything
Closing this and starting again
This is my first attempt
These patches have been compile tested, and I've set up an OpenAM instance using my scripts
They haven't been tested further than that I'd be grateful if you could take a look
If you're happy with them I'll work on some more of them tomorrow