search

Formfeed-UK / nova-breadcrumbs

Augments Nova 4 Breadcrumbs with nesting and resource/static override methods
MIT License
19 stars 8 forks source link

Would it make sense to remove the link from the Dashboard name in the Breadcrumb? #15

Closed mtessar closed 1 year ago

mtessar commented 1 year ago

I noticed that the Dashboard Breadcrumbs has a link to the current dashboard.

https://github.com/Formfeed-UK/nova-breadcrumbs/blob/main/src/Breadcrumbs.php#L76

Does it make sense to remove the link on this node to be consistent with the other items. I can create a pull request if you would like.

ianrobertsFF commented 1 year ago

Yeah this makes sense, ill do the change tomorrow, no need for a PR