search

Formfeed-UK / nova-breadcrumbs

Augments Nova 4 Breadcrumbs with nesting and resource/static override methods
MIT License
19 stars 8 forks source link

Breadcrumb links to Lenses #16

Open mtessar opened 1 year ago

mtessar commented 1 year ago

Would it make sense to add a node for the current lens when viewing a lens within a resource to the breadcrumb?

ianrobertsFF commented 1 year ago

Can you elaborate? I'm not sure what you're asking for here.

Do you mean, for example Home -> Your Resource -> Your Lens?

The caveat of that is that currently I don't have a reliable way to then allow for that path to go deeper, IE Home -> Your Resource -> Your Lens -> Resource Record it would instead continue to Home -> Your Resource -> Resource Record upon displaying a record, which is inconsistent from the location the user was previously at, and doesn't offer a direct return path.

I am currently working on allowing for this functionality, but it's not simple, and will require a bit of a rewrite, assuming I can get it working at all (although I'm hoping there should be nothing breaking for current use cases)

mtessar commented 1 year ago

Sorry for the lack of clarity. This was exactly what I was thinking about:

Home -> Your Resource -> Your Lens

It totally makes sense that if you went to a record from the lens it would reset the Breadcrumb to Home -> Your Resource -> Resource Record and I can see how that might be a little unclear to the user. It does also make sense a little bit though. I think it's a trade off I would be good with.

Totally makes sense that it's not simple. Thanks for making an awesome package.

ianrobertsFF commented 1 year ago

I'll implement it, but it will be an opt-in via a config entry(globally)/static property, as this will almost certainly be a breaking change when I finish the functionality allowing for a more fluid path of breadcrumbs for things like Dashboards/Lenses

mtessar commented 1 year ago

That would be awesome. Thanks!