FormidableLabs / react-game-kit

Component library for making games with React & React Native
http://reactnext.surge.sh
MIT License
4.62k stars 309 forks source link

Keypress in demo fires twice for Firefox #70

Open joshball opened 6 years ago

joshball commented 6 years ago

https://github.com/FormidableLabs/react-game-kit/blob/master/demo/slides/index.js#L36-L37 Adds both keyupand keypresslisteners. In Chrome/Edge, the arrow keys only fire keyup. But in Firefox, both events get fired and it results in a double key press. I don't know if it a matter of just removing the keypresshandler? Or keeping both and handling it with some logic on the browser type? I am not a front end guy, and googling hasn't led me to a definitive solution, so if you have thoughts, I am sure you all handle this kind of stuff all the time. I am happy to submit a PR if you suggest a solution.