search

FormidableLabs / react-native-ama

Accessibility as a First-Class Citizen with React Native AMA
https://commerce.nearform.com/open-source/react-native-ama/
MIT License
236 stars 16 forks source link

Make ScrollView in BottomSheet optional #210

Closed proohit closed 1 month ago

proohit commented 1 month ago

Is there an existing issue for this?

Code of Conduct

Feature Request

Hey there, and thanks for this library! It has enabled us to provide accessible bottom sheets in our app.

Just one question: Is there a way to not a ScrollView as the container for the content inside a BottomSheet? Currently, if a bottom sheet contains large lists (which should be virtualized), there is no way to virtualize these lists, as BottomSheet forces a ScrollView which then doesn't allow e.g. FlatList or SectionList to be used as the content.

ceceppa commented 1 month ago

Hi, at the moment is not possible. You could create a patch file for your local project to make the ScrollView optional. However, we're in the process of converting this project into a monorepo and we can add this feature for the next release.

proohit commented 1 month ago

Thanks. For now, I solved this by making the bottom sheet horizontal scrollable and width 100%. That way, I can add whatever vertical scrolling view inside the bottom sheet.

Longterm, I think I'd be good to make the ScrollView optional altogether.