Closed brybrophy closed 6 years ago
I decided to continue with this PR and use it to upgrade the dependencies in this project. Not sure why yet, but the build continues to fail on Travis. The build, tests, and demo are all working locally. I am wondering if the node_modules are being cached by Travis, since the error that is breaking the build there has to do with an old version of a package. I will see if I can get it working.
Got it! It was an issue with babel-jest having a bad peer dependency on babel-core 7.0.0, which was replaced by babel with @babel/core 7.0.1
Aside from upgrading dependencies, I also had to work on the tests, as Enzyme v3 changed the way it does things a bit. I fixed tests without changing their intentions, and add 1 more test into the suite.
@sarmeyer do you know if anyone is maintaining this project? I doesn't seem like it based on the commit history.
@brybrophy - I’m on parental leave and won’t be back for a few weeks. Thanks for this great work!!!
@boygirl - Can we find if someone has some time to verify and release this? Thanks!
@brybrophy Thanks for this change! I tested locally, and everything is working as expected. Merging.
Great! Happy to help.
👏
@ryan-roemer This pull request fixes #19 by replacing componentWillReceiveProps with componentDidUpdate. I also upgraded react, react-dom, enzyme, and enzyme-react-adapter-16 to the latest versions.