FormidableLabs / victory

A collection of composable React components for building interactive data visualizations
http://commerce.nearform.com/open-source/victory/
Other
10.97k stars 526 forks source link

Zooming on VictoryZoomContainer is slow - victory-native #2180

Closed St0wy closed 5 months ago

St0wy commented 2 years ago

The Problem

Zooming on the VictoryZoomContrainer reduces the framerate as low as 10 FPS. I don't have a lot of data, I'm just testing with a VictoryLine, but it also happens without anything on the chart.

Reproduction

Here is my code :

import { View } from "react-native";
import {
  VictoryLine,
  VictoryChart,
  VictoryTheme,
  VictoryZoomContainer,
} from "victory-native";

export default function App() {
  return (
    <View>
      <VictoryChart
        theme={VictoryTheme.material}
        containerComponent={<VictoryZoomContainer />}
      >
        <VictoryLine
          data={[
            { x: -1, y: -1 },
            { x: 1, y: 1 },
          ]}
        />
      </VictoryChart>
    </View>
  );
}
vtarelkin commented 2 years ago

@St0wy same. any workarounds?

St0wy commented 2 years ago

@vtarelkin In the end I disabled the zoom and used an other library (react-native-border-zoom-view).

acharyakavita commented 8 months ago

Hi everyone, we are transitioning all Native development to our new Victory Native XL library which is purpose built for supporting Native. Many of the design decisions we made in this version of Victory is not ideal for Native development.

github-actions[bot] commented 5 months ago

This issue is stale because it has been open for 90 days with no activity. If there is no activity in the next 7 days, the issue will be closed.

github-actions[bot] commented 5 months ago

This issue was closed because it has been inactive for 7 days since being marked as stale. Please open a new issue if you believe you are encountering a related problem.