search

FormingWorlds / PROTEUS

Coupled atmosphere-interior framework to simulate the temporal evolution of rocky planets.
https://fwl-proteus.readthedocs.io
Apache License 2.0
12 stars 1 forks source link

Harmonize access to Socrates from PROTEUS #134

Closed lsoucasse closed 2 months ago

lsoucasse commented 3 months ago

At the moment JANUS and AGNI have their own tools to download and install SOCRATES. When you use PROTEUS, you should be able to switch JANUS / AGNI while having only one SOCRATES code installed.

nichollsh commented 3 months ago

Definitely agree. AGNI needs RAD_DIR to be set, and the Julia wrapper to be compiled in the SOCRATES repository (it will do this when pkg> build is first run).

nichollsh commented 3 months ago

See also https://github.com/FormingWorlds/JANUS/issues/51

lsoucasse commented 2 months ago

Just tested to swap from Janus to Agni using the same Socrates repository. It just works fine. When installing the Julia Agni package it just adds the julia wrapper into the socrates repo. I think we just need to remove the get_socrates command in the documentation when using AGNI, assuming socrates is already there as it is a core module.

nichollsh commented 2 months ago

That's great - glad to hear it works nicely. Presumably we will then add a get_socrates script of some form into PROTEUS? Or will it be automatically compiled in some way?

lsoucasse commented 2 months ago

Yes, when we remove Socrates as a submodule we need to write a cli command that runs the download and the basic compiling of Socrates. Then if you install agni it will build the julia wrapper on top of it.

lsoucasse commented 2 months ago

Closing this issue, I will address the documentation update when working on #135.