search

FormingWorlds / PROTEUS

Coupled atmosphere-interior framework to simulate the temporal evolution of rocky planets.
https://fwl-proteus.readthedocs.io
Apache License 2.0
12 stars 1 forks source link

Tests: MacOS runner #172

Closed nichollsh closed 1 month ago

nichollsh commented 2 months ago

It would be useful to setup the tests to run a matrix of different Linux and Python versions, in order to catch potential issues which arise only for certain platforms.

C.f. https://github.com/FormingWorlds/MORS/issues/22

nichollsh commented 2 months ago

At the same time, we should use V4 of the Cache action, since the current V3 has some significant slowness when doing the post-job clean up step. I have noticed that the action seems to 'hang' for several minutes after the cache step has completed, which has also been noted here: https://github.com/actions/toolkit/issues/1578#issuecomment-2253355054.

nichollsh commented 2 months ago

The above issue with Cache V4 has been resolved.

Seems like the only runner images are Ubuntu, MacOS, and windows. We could add a MacOS one, but unfortunately the Linux side is limited to Ubuntu. There's no planned support for Windows, since they can just use WSL.

stefsmeets commented 2 months ago

What issues do you expect on a non-ubuntu linux?

nichollsh commented 2 months ago

I don't have any in mind specifically, but the issue that Laurent has been facing (MORS getting different values on different platforms, despite being pure Python) indicates that this is something that we should consider.