search

FormingWorlds / PROTEUS

Coupled atmosphere-interior framework to simulate the temporal evolution of rocky planets.
https://fwl-proteus.readthedocs.io
Apache License 2.0
12 stars 1 forks source link

Read aragog output files and make interior plots #239

Closed nichollsh closed 3 weeks ago

nichollsh commented 3 weeks ago

Calls the Output.write_at_time() function in Aragog, which will write a NetCDF file at each PROTEUS iteration - this means we will have 1 interior and 1 atmosphere NetCDF file at each step. Generalised the manner in which these data are accessed between SPIDER and Aragog, so we don't have duplicated plotting code. Added functionality to read and plot Aragog model results when coupled to PROTEUS. This will complete one of the tasks in https://github.com/FormingWorlds/PROTEUS/issues/236

Requires the corresponding Aragog branches to be merged first.

Bump Mors version - support for Python 3.13

nichollsh commented 3 weeks ago

Encountered a slightly odd issue with the Ruff linting. Running ruff check --fix locally produces import blocks which fail the code style checks on the CI. Solution was to manually adjust the whitespace in the import blocks until the CI was happy.

nichollsh commented 3 weeks ago

Hi @timlichtenberg - could you review this please? If you want to test it, you will need to use my aragog branch: https://github.com/ExPlanetology/aragog/tree/hn/writefiles

nichollsh commented 3 weeks ago

I agree. It's difficult not knowing if anything has broken at the moment, other than just by running the code and seeing if it looks fine. However, with this merged we should now be able to directly tackle #237.

Thanks for the review!