search

FormingWorlds / PROTEUS

Coupled atmosphere-interior framework to simulate the temporal evolution of rocky planets.
https://fwl-proteus.readthedocs.io
Apache License 2.0
12 stars 1 forks source link

Condition on Pxuv computation (only for Zephyrus escape) + check on Mors/Baraffe tracks #258

Open EmmaPostolec opened 1 week ago

EmmaPostolec commented 1 week ago

Add few lines in the atmos_clim wrapper to compute Pxuv only if zephyrus is activated as suggested by @lsoucasse in #227

Quotting @lsoucasse here : " It would be worth adding an "if zephyrus activated" statement to the Pxuv computation, and if not fill the Pxuv entry with the surface pressure. I think it kind of goes with issue https://github.com/FormingWorlds/PROTEUS/issues/232. "

lsoucasse commented 1 week ago

Could you also add in this work a check that Mors/Baraffe tracks are selected when running zephyrus. It should break if not. Then it will solve #232 .

timlichtenberg commented 4 days ago

Why is Zephyrus incompatible with Spada tracks btw?

lsoucasse commented 4 days ago

Why is Zephyrus incompatible with Spada tracks btw?

It is the other way around. Zephyrus can only work if Spada tracks (Mors) are used.

timlichtenberg commented 4 days ago

Ok, thanks for clarifying! This means Spada tracks should always be the default option in all config files.