search

FormingWorlds / PROTEUS

Coupled atmosphere-interior framework to simulate the temporal evolution of rocky planets.
https://fwl-proteus.readthedocs.io
Apache License 2.0
12 stars 1 forks source link

Ls/resume aragog #279

Closed lsoucasse closed 2 days ago

lsoucasse commented 2 days ago

This works allows Aragog to resume a simulation by reading init temperature file from output repository. It seems to behave well except for the mantle mass and gravity but it is a separate issue #277 . It also prompts the aragog logging. I hard coded the default level but we can easily make it configurable.

nichollsh commented 2 days ago

Why has the resume functionality now moved to the configuration file? Isn't it better to keep it as a flag, so that we don't have to edit the configuration file in order to resume a simulation?

lsoucasse commented 2 days ago

Why has the resume functionality now moved to the configuration file? Isn't it better to keep it as a flag, so that we don't have to edit the configuration file in order to resume a simulation?

I need Aragog to know whether we resume or not because the way to access the initial temperature is different. I found it was a nice way to pass the information via the config object. The resume argument is part of the config but you don't need to set it up in the config file (also it could be an option) as default is false and it is turned to true when you use the resume flag.

nichollsh commented 2 days ago

Ah okay. That's fine with me - thanks!