search

FountainJS / generator-fountain-webpack

Yeoman 'fountain' generator which handle the Webpack config
http://fountainjs.io
MIT License
4 stars 6 forks source link

webpackChangeHandler does not use correct errrorHandler #46

Closed pusherman closed 8 years ago

pusherman commented 8 years ago

webpackChangeHandler has

conf.errorHandler('Webpack')(err);

but conf is the webpack.conf not gulp.conf.

If gulp.conf is used, this.emit is not valid since this is the gulp.conf object.

micaelmbagira commented 8 years ago

Hi @pusherman thanks for reporting, this is a bug indeed

pusherman commented 8 years ago

@micaelmbagira this is exactly what I tried locally but this caused another issue.

this.emit in the error handler is undefined because the error is coming from webpack and not a gulp stream. Since it doesn't emit 'end' gulp just pauses without exiting.