FourthState / plasma-mvp-sidechain

Cosmos SDK (Tendermint consensus) side-chain implementation for plasma
Apache License 2.0
112 stars 35 forks source link

Update Errors #152

Closed colin-axner closed 4 years ago

colin-axner commented 5 years ago

Summary

The errors are not consistent within the codebase. We should follow golang guidelines for errors, as well as add errors.go files to each module and with the correct codespace. For example, "handlers" could be a codespace with a ErrTxDNE error type.
colin-axner commented 5 years ago

refactor DNE errors into one

hamdiallam commented 4 years ago

Also remove the braces : { %s } when wrapping errors. Instead it should be fmt.Errorf("some error: %s", suberr)