search

FourthState / plasma-mvp-sidechain

Cosmos SDK (Tendermint consensus) side-chain implementation for plasma
Apache License 2.0
112 stars 35 forks source link

Hamdi/store #165

Closed hamdiallam closed 5 years ago

hamdiallam commented 5 years ago

1.) ctx back in getProof 2.) store.Block doesn't need to implement the RLP interface 3.) constants for the store names

AdityaSripal commented 5 years ago

What is the reason for putting ctx back in? Is it code-hygeine or a correctness issue?

Also need to understand how trust-node flag factors in to commands.

hamdiallam commented 5 years ago

I put the ctx back in because i think the caller should be responsible for constructing it's ctx object.

--trust-node is the same as used by default in the cosmos sdk. If it's not set, the --chain-id must be set so that the responses can be verified. The trust-node/chain-id flags are only there if the command deals with any interaction with a full node

codecov-io commented 5 years ago

Codecov Report

Merging #165 into develop will decrease coverage by 0.35%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #165      +/-   ##
===========================================
- Coverage    59.03%   58.67%   -0.36%     
===========================================
  Files           27       27              
  Lines         1196     1176      -20     
===========================================
- Hits           706      690      -16     
+ Misses         379      377       -2     
+ Partials       111      109       -2
Impacted Files Coverage Δ
store/outputStore.go 68.55% <ø> (ø) :arrow_up:
plasma/block.go 100% <ø> (+15.38%) :arrow_up:
store/blockStore.go 81.57% <ø> (ø) :arrow_up:
store/keys.go 100% <ø> (ø) :arrow_up:
store/types.go 0% <0%> (-29.17%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e6563d9...153f5cd. Read the comment docs.