search

FoxComm / highlander

Because there can only be one
MIT License
9 stars 3 forks source link

Variant choice de-selects itself #1375

Open stresslimit opened 7 years ago

stresslimit commented 7 years ago
  1. Go to https://demo.foxcommerce.com/products/neon-tank-top
  2. Click size
  3. Click the first color
  4. Size gets de-selected
stresslimit commented 7 years ago

@bswineford just suggested maybe it de-selected because we have no stock. So what should happen is that you select a size, and color filters out choices that we have no stock or SKU/variant for that size/color combo. OR, that color becomes disabled and when we click we get a message "out of stock"

bswineford commented 7 years ago

Yup, seems to be because there was no variant created for some of these combinations.

banners_and_alerts_and_foxcommerce

Would be nice to auto-disable the colors that are not available in the selected size AND/OR disable sizes that aren't available if a particular color is selected. If it's not possible (or very difficult) to do that right now, then when you select a color that is not available in that size, we should show a message, "This item is out of stock."

anru commented 7 years ago

@mourningking @bswineford both variants are works for me. I asked @mourningking for final behavior which we should do

anru commented 7 years ago

Weird. It's already has been fixed there https://github.com/FoxComm/highlander/pull/1588