Symfony 4 compatibility

FrDeamon / EnseparHtml2pdfBundle

Html2pdf for Symfony 2 as a service.

MIT License

22 stars 22 forks source link

Symfony 4 compatibility #33

Closed olix21 closed 4 years ago

olix21 commented 5 years ago

Hello,

Is Symfony 4 support planned? I can work on that and make a PR. I just need a green light to begin the dev. I see there is a PR to split the symfony dependency but it didn't make it...

OwlyCode commented 5 years ago

Hello,

If you can contribute this I would gladly merge! The other PR didn't make it because the test suite is broken. If you need any help let me know!

olix21 commented 5 years ago

done here: https://github.com/OwlyCode/EnseparHtml2pdfBundle/pull/34

OwlyCode commented 4 years ago

This is now tagged as v4.0.1