search

FrSkyRC / ETHOS-Feedback-Community

Feedback & suggestions are welcomed here for ETHOS by FrSky
188 stars 85 forks source link

Mixers library a tad inconsistent #3422

Open Jedsters opened 7 months ago

Jedsters commented 7 months ago

A very minor observation which you may want to tweak next time you're in that area of code...

I notice if you create a new glider with no motor then quite reasonably you don't get a Throttle mix in the Mixes library. Although you do get Thr=>Ele and Thr=>Rud. I'd suggest that these two should be linked to the Throttle mix and be present or not when the Throttle mix is or isn't.

There are other very minor similar inconsistencies too around absence of flaps and mixes which involve flaps etc., but given they may need more code changing related to being added if flaps get added it's probably not worth risking problems to adjust those. There's obviously already a test for a throttle being added so that one seems to make sense to add to, one day...

mawzthefinn commented 7 months ago

That's a good point, it probably would be best overall to hide any mixers that depend on other mixers if the dependencies are not provisioned to the Mixers page already. That would solve the Throttle-derived and Flap-derived mixers from showing up when they depend on specific mixers that aren't present.

bsongis-frsky commented 7 months ago

I prefer keep this for 1.5.1 to avoid an absurd last minute mistake

Jedsters commented 7 months ago

Absolutely!