Fragtality / PilotsDeck

Directly control the FlightSim from your StreamDeck!
Other
93 stars 6 forks source link

Possible LVAR Issue in 0.8.0 #71

Closed KR283 closed 2 weeks ago

KR283 commented 1 month ago

Hi @Fragtality ,

I've been testing v0.8.0, and for the most part have not had any issues :)

One I've come across that's not been noted elsewhere is a strange behaviour reading L:A32NX_AUTOPILOT_HEADING_SELECTED. Screenshot shows an export of the LVARS as seen by FSUIPC, and the output on the streamdeck - I've not seen this behaviour on any other LVARS (yet!)

image

KR283 commented 1 month ago

Same button on 0.7.12: image

Fragtality commented 1 month ago

Great to hear!

I assume that Comparison was made against the same FBW Version? If yes, that is really a good Catch! I've stumbled across this too when redoing the FBW Profile and thought it was just a Thing they had changed in the mean Time. Sometimes the FBW is a bit "over engineered" so they write some L-Vars with the correct Unit instead of just a Number. When you read that L-Var with the correct Unit of Degrees you get the expected Value: C:(L:A32NX_AUTOPILOT_HEADING_SELECTED, Degrees)

But apparently the old Codebase (which I was very focused to get away from xD) did that somehow better respectively in a general Way so that the Value is automatically in the correct Unit. Guess I have to dig through the old Code and have a Look what the Difference is and how I apply it without breaking anything 🤔

Fragtality commented 1 month ago

Check out the latest Commit - I reverted the Behavior. Could only do quick Test on P3D on MSFS, but it should now work as before.

KR283 commented 1 month ago

I'll check now - thanks

KR283 commented 1 month ago

Now working as expected thanks!

KR283 commented 1 month ago

One other I've noticed - has the scaling changed on the SD+ LCD? Previously an oversized image was scaled to fit the LCD, but current behaviour doesn't seem to do this:

image vs image

Fragtality commented 1 month ago

It is basically a new Plugin - so yes, there were also many Changes to the Rendering of Images. 😅

Won't do anything about it because: 1) Could have used the correct Image Size & correct Suffixes in the first Place (as was/is recommended) 2) The Draw Rectangle can be configured on all "classic" Actions to tweak an Image 3) The Composite Action allows even more Tweaking of Image Alignment, Size and Position

Especially with the Composite Action, it could be evaluated if an Image is needed at all in that Use-Case - since you could simply define a Text Element for "SPEED"

Fragtality commented 1 month ago

Btw - my Profile for the FBW will also be updated (well it is already updated, just waits for everything to be ready for Release) - so you might consider to not put too much work in a FBW Profile. Unless you really really want to build your own Stuff ofc! 😉

image

KR283 commented 1 month ago

Is it possible to use B: vars within calculator code? I've managed to accomplish this through the Composite Action (Which I Love!!)

Fragtality commented 1 month ago

I don't know - this is more a Question what the Simulator allows than what PilotsDeck allows. It just passes the RPN Code as-is to the MF Module which then calls the execute_calculator_code Function with that Code.