FreakyAli / Maui.FreakyControls

FreakyControls is a free OSS UI Kit for .NET MAUI which provides a set of controls and utilities to build modern mobile apps.
MIT License
312 stars 37 forks source link

Cancel Button and OnKeyboardClicked Events #117

Closed DgkanatsiosMasoutis closed 6 months ago

DgkanatsiosMasoutis commented 6 months ago

Even if the buttons are visible and clickable there are no events for the CancelButton and the Keyboard.

FreakyAli commented 6 months ago

What control are we talking about here again??

DgkanatsiosMasoutis commented 6 months ago

Sorry i that i didn't mention it. The FreakyPinCodeControl. I saw that in the wiki describes an Event called Keyboard_Clicked, tried to find it in previous versions but doesn't exist.

DgkanatsiosMasoutis commented 6 months ago

It will be great to include those two events!

FreakyAli commented 6 months ago

tried to find it in previous versions but doesn't exist.

What version are you on currently?

DgkanatsiosMasoutis commented 6 months ago

tried to find it in previous versions but doesn't exist.

What version are you on currently?

0.4.10

FreakyAli commented 6 months ago

I just checked the documentation and I have not mentioned any of these events, is this a feature request?

https://github.com/FreakyAli/Maui.FreakyControls/wiki/FreakyPinCodeControl

DgkanatsiosMasoutis commented 6 months ago

I just checked the documentation and I have not mentioned any of these events, is this a feature request?

https://github.com/FreakyAli/Maui.FreakyControls/wiki/FreakyPinCodeControl

It is but also if you look at the remarks you mentioned Use event handlers like Keyboard_Clicked to update the code value when virtual keyboard buttons are pressed.. Unless you are not talking about that then it is my fault.

FreakyAli commented 6 months ago

That is an internal event that I forgot to mention, Anyway I can do this whenever I make the next release, also please in case of future bugs follow the bug template thanks!

Hope this is not something you need urgently

FreakyAli commented 6 months ago

@DgkanatsiosMasoutis FYI your changes are in the PR, the next pre-release will be released this weekend 😄

https://github.com/FreakyAli/Maui.FreakyControls/blob/377292e958b4fd977f1352db21df797dbdac9618/MAUI.FreakyControls/MAUI.FreakyControls/Shared/FreakyCodeView/FreakyPinCodeControl.xaml.cs#L10

DgkanatsiosMasoutis commented 6 months ago

@DgkanatsiosMasoutis FYI your changes are in the PR, the next pre-release will be released this weekend 😄

https://github.com/FreakyAli/Maui.FreakyControls/blob/377292e958b4fd977f1352db21df797dbdac9618/MAUI.FreakyControls/MAUI.FreakyControls/Shared/FreakyCodeView/FreakyPinCodeControl.xaml.cs#L10

Thats great news!! Also i wanted to ask you, will this be the same event for cancel button? Thanks for your time and effort!

FreakyAli commented 6 months ago

No there are 3 events, for the numbers, the cancel button and the backspace button, hope this helps

DgkanatsiosMasoutis commented 6 months ago

No there are 3 events, for the numbers, the cancel button and the backspace button, hope this helps

It helps a lot! Many thanks!

FreakyAli commented 6 months ago

@DgkanatsiosMasoutis Checkout the latest release