Add App shortcuts - Githubissues

FredJul / Flym

Flym News Reader is a light Android feed reader (RSS/Atom)

Other

952 stars 405 forks source link

Add App shortcuts #578

Closed lavendthomas closed 4 years ago

lavendthomas commented 4 years ago

The following picture is self-explanatory, app shortcuts are especially useful to add a permanent shortcut to the favorites to the home screen, for example.

I'm not sure about 2 things:

It needs API Level 25 minimum, I'm not that familiar about Android Development so maybe I did something wrong, and I have only tested on API Level 29.
I don't like how I wrote the green icons, by scaling and translating, but it works quite well.

:appshortcuts

FredJul commented 4 years ago

For someone who are not familiar with Android development you clearly shows good skills!

Concerning your two points:

I see nothing in your PR which can fail on API<25, shortcuts will only be ignored
the scaling and translating of icons is certainly not nice, but I don't know a better solution, so that's OK for me

FredJul commented 4 years ago

By the way, since I myself lack times to correctly improve/maintain Flym, would you like to have more permissions on this project? I will not abandon the project and will continue to do some changes, but you would be able to directly commit. I believe you have the necessary competences and motivation for that. I can also share with you what I think could be improved in the current code.

Or we continues with the current PR way, which is totally fine for me as well.

lavendthomas commented 4 years ago

Thank you for the kind words, I'll gladly accept to be added to be added to the collaborators as I have a few improvements in mind. It will probably reduce workload for you as well. However, I think I'm still gonna use PR for non-trivial changes for now, to be sure I don't introduce new bugs.