support multi-entrypoint bundling(webpack)

FredKSchott / create-snowpack-app

The all-in-one app template for Snowpack. [moved]

https://www.snowpack.dev

Other

727 stars 96 forks source link

Closed W1U02 closed 4 years ago

W1U02 commented 4 years ago

add multiply entrypoint support for webpack-plugin
- change bundled file name to [name].[hash].js and [name].[hash].css
- use filename as entrypoint name, if there are duplicated name, throw an error
fix a bug caused by introducing buildOptions

FredKSchott commented 4 years ago

Awesome! Thanks for contributing. @drwpow want to review this one?

W1U02 commented 4 years ago

It still only work for SPA, but can support the case that have more than one local js file.

drwpow commented 4 years ago

@W1U02 the spelling error is the only change you might want to make; otherwise it’s amazing. Ready to merge whenever you’re ready!

W1U02 commented 4 years ago

@drwpow thanks for the comments. I've make an update.

change [hash] to [contenthash] fix typo duplictate to duplicate

drwpow commented 4 years ago

Awesome work, @W1U02! 🙏

haikyuu commented 4 years ago

Can someone help me with buildOptions error. How can i fix it while waiting for the new release?

Where should i include the buildOptions object? I tried in a bunch of places but none worked

drwpow commented 4 years ago

@haikyuu buildOptions goes in your snowpack.config.js file, which you can read more about here: https://www.snowpack.dev/#configuration

haikyuu commented 4 years ago

Thank you @drwpow