search

FredKSchott / create-snowpack-app

The all-in-one app template for Snowpack. [moved]
https://www.snowpack.dev
Other
727 stars 96 forks source link

Feature request: Add pnpm as install option #159

Closed David-Else closed 4 years ago

David-Else commented 4 years ago

I see there is a --use-yarn option, would be great to add --use-pnpm!

https://pnpm.js.org/

FredKSchott commented 4 years ago

+1! Would love to see this added if anyone is willing to tackle!

stramel commented 4 years ago

@FredKSchott Are you thinking that we would offer a --use-pnpm option? Or do you have thoughts on something like --skip-install or --use-installler=pnpm/--use-installer=yarn?

David-Else commented 4 years ago

@FredKSchott I had a quick look at https://github.com/pikapkg/create-snowpack-app/blob/master/packages/create-snowpack-app/index.js and I would love to have a go, I am new to Node.js but it doesn't look too confusing.

Could you quickly confirm there are no other files involved and it is just a case of modifying the logic here? I would change those ternaries to switches, does that sound about right?

FredKSchott commented 4 years ago

I'd prefer --use-pnpm for now, but that doesn't mean we couldn't represent this in the code as installer = 'npm' | 'yarn' | 'pnpm'.

@David-Else thanks for offering to tackle! Yup, it should only affect the output and how you run the first install in the project. Also, the README should be updated to mention this

David-Else commented 4 years ago

@FredKSchott Cool, I will do it. You can mark this issue assigned if you like, I am not sure how you do things around here.