Frederick888 / external-editor-revived

External Editor Revived is a Thunderbird MailExtension which allows editing emails in programs such as Vim, Neovim, Emacs, etc.

GNU General Public License v3.0

110 stars 6 forks source link

Fixes default options for Neovide to spec #144

Closed ekorchmar closed 8 months ago

ekorchmar commented 8 months ago

Adresses issue #143

Description

Single commit, changing --nofork to --no-fork

Changes

Checklist

[x] I have rebased my branch so that it has no conflicts
[ ] I have added tests where appropriate
[ ] Commit messages are compliant with Conventional Commits

Is this a breaking change?

No, fixes existing problem without affecting other modules behavior

Test results

OS: Linux
Thunderbird version: 115 Tested manually to observe expected behavior -- the editor can start.

Frederick888 commented 8 months ago

Conventional commits please. Something like

fix(ext): Update default Neovide argument to --no-fork

[1] https://github.com/neovide/neovide/commit/5743356d654dbeaf213c0da3e2988c4d89c218e1#diff-4583b895d17596f30dcbac33a7d47de9c210df2c07210bb0775b7c27097345daR55

Frederick888 commented 8 months ago

Huh? Sorry I didn't want to close this. What happened...?

Frederick888 commented 8 months ago

Oh... One of my git subcommands didn't play well with gh's checkout style (no remote, branch config only).

I just merged it manually and pushed. Thanks for the contribution!