Free-Code-Camp-Seoul / fcc-seoul-website

FCC Seoul Website
https://fcc-seoul.fly.dev
5 stars 8 forks source link

Husky install deprecated #89

Open GMSoudersJr opened 2 weeks ago

GMSoudersJr commented 2 weeks ago

Is this worth fixing?

image

image

So husky init isn't an option.

According to the How To Section # Manual Setup image

Current package.json:

"scripts": {
  "prepare": "husky install",
}

Should be changed to:

"scripts": {
  "postinstall": "husky",
}

or simply:

"scripts": {
  "prepare": "husky",
}

since it seems to work fine. If not, I guess the README.md would need to be updated as well:

image

We already have this with yarn pre-commit instead

image

Thoughts...

GMSoudersJr commented 2 weeks ago

And there's more

image