search

FreeAndFair / ColoradoRLA

Software to facilitate risk-limiting audits at the state level, developed for the state of Colorado.
Other
21 stars 8 forks source link

Audit board enters comment and submits ballot; comment not recorded in database #889

Closed sfsinger19103 closed 7 years ago

sfsinger19103 commented 7 years ago

Query below was made a few minutes after submission of a ballot card review with text entered in the comment box. The db did have a record of the audit board review of the ballot in question, but no comment was recorded.

corla=# select distinct comment from cvr_contest_info ;
     comment      
------------------

 ballot not found
(2 rows)

corla=#
dmzimmerman commented 7 years ago

I have tested this by modifying the Python smoketest client to submit comments with its ballots, and those comments ended up in the database. So I don't think this is a server-side issue.

dmzimmerman commented 7 years ago

This is definitely a client issue; the client is using the JSON key comments for the comments, but the key on the server side is actually comment.

dmzimmerman commented 7 years ago

This is a worse client issue than I thought. The client is, in fact, simply never sending comments - incorrect key or no. Verified by Wireshark monitoring of client/server connection.