search

FreeCAD / DevelopersHandbook

A handbook about FreeCAD development
47 stars 30 forks source link

Don't gitignore Bundler install path config #59

Closed kkremitzki closed 1 year ago

kkremitzki commented 1 year ago

Closes #58

chennes commented 1 year ago

Is it necessary to change the .gitignore in this case? Does this file get changed often?

kkremitzki commented 1 year ago

It isn't strictly necessary, but I can't think of a significant reason not to do so. There are a few ways to approach this problem, but the benefit with this one is that it prevents someone from possibly messing up their system Ruby install by including the config at a project level. It's similar in principle to how Debian's system pip was recently changed to no longer allows pip install outside of a virtualenv.

The instructions could tell the user to run bundle config set path vendor/bundle, creating the .bundle/config file included in this PR, but that would probably need to go with an explanation of why one should do it, forcing a bit of a tangent, and if that step was omitted, the breakage could occur.

A possible downside would be that if someone already has set a bundle install path at the user level, the project-level config would override it, but I would suspect in that case the user would have enough background to notice and decide on a change for their own use case.

chennes commented 1 year ago

Fair enough. I'll merge as-is.