search

FreeCAD / FreeCAD-addons

A convenient gathering of useful and well-developed FreeCAD plugins made by the community.
771 stars 253 forks source link

Add Turning addon #268

Closed dubstar-04 closed 10 months ago

dubstar-04 commented 1 year ago

Will the addon manager resolve submodules included in addons?

luzpaz commented 1 year ago

We just prefer to add the submodules on our end.

luzpaz commented 1 year ago

We can add manually, no worries. Is this PR ready ?

dubstar-04 commented 1 year ago

I would prefer to hold the PR. I've made some significant improvements to the code and it would be best if I released a video explaining how to use the add-on.

The Add-on includes a submodule for liblathe. I was hoping that the addon manager would resolve the submodule itself then I could release new addon versions as I develop liblathe.

luzpaz commented 1 year ago

is liblathe on pypi ?

@chennes what is the addon manager policy on including submodules inside addons? Do we prefer to have them approved and added to https://github.com/FreeCAD/FreeCAD-addons/blob/master/ALLOWED_PYTHON_PACKAGES.txt ?

dubstar-04 commented 1 year ago

Liblathe isn't currently published on pypi but there is a script to automate publishing: https://github.com/dubstar-04/LibLathe/blob/master/publish.py

I can publish it if required.

Are approved pypi modules automatically downloaded and updated with the associated addon?

dubstar-04 commented 1 year ago

Alternatively I can create a separate addon for liblathe?

chennes commented 1 year ago

If your module is available via PyPi then the Addon Manager can automatically install it. The same is true if you make it a FreeCAD Addon. There is a file in this repo that contains an AllowList for PyPi packages that we would need to add it to.

dubstar-04 commented 1 year ago

Thanks for the reply. Please leave this PR draft and I will let you know when it's ready. I'm on vacation this week but hopefully find time next week.

chennes commented 10 months ago

@dubstar-04 is there any update on this?

dubstar-04 commented 10 months ago

I created a PyPi package for liblathe. That appears to install and work as expected, however I don't have time to finish the work at the moment. I will closed this PR.