search

FreeCAD / FreeCAD-addons

A convenient gathering of useful and well-developed FreeCAD plugins made by the community.
771 stars 253 forks source link

Added the FreeCAD Stream Deck Addon module #290

Closed Giraut closed 9 months ago

chennes commented 9 months ago

I've also submitted three issues to your repository for the things that should be changed in package.xml so that the Addon Manager reads it correctly.

Giraut commented 9 months ago

I've also submitted three issues to your repository for the things that should be changed in package.xml so that the Addon Manager reads it correctly.

Thanks. They are fixed.

chennes commented 9 months ago

This will appear in the Addon Manager next time people recache. The addon stats from GitHub will be updated at around midnight CET and yours will be available then.

Giraut commented 9 months ago

Thanks!

Giraut commented 9 months ago

Hmm I see it, but there is one thing: I thought it had to be sorted alphabetically by path, but apparently it was by human readable name.

As a result, Stream Deck Addon (the human-readable name) appears between "freecad.gears workbench" and "GDML workbench" because the path is "freecad_streamdeck_addon".

Do you want me to submit a new PR to move it after "SteelColumn" where it should be?

chennes commented 9 months ago

Do you mean in the .gitmodules file?

Giraut commented 9 months ago

Yes. It's a bit confusing because the path "freecad_streamdeck_addon" is in the right place alphabetically, but what's displayed in the FreeCAD addon manager is the human-readable name "Stream Deck Addon", and that definitely isn't.

I thought it didn't matter and FreeCAD would sort the list after refreshing the cache, but it doesn't. It just goes by the order in .gitmodules.

EDIT: Actually I just rechecked and it's a bit more complicated than that: after you refresh the cache, "Stream Deck Addon" is indeed at the wrong spot somewhere in the F's. But if you close the addon manager and open it again, then the list of addons is sorted and "Stream Deck Addon" now appears at the correct spot in the S's.

So it's only out of place after a cache refresh - meaning the addon manager probably should sort the addon names afresh after that operation and it doesn't.