FreeLanguageTools / vocabsieve

Simple sentence mining tool for language learning
GNU General Public License v3.0
394 stars 30 forks source link

Wikitionary Dictionary always gives "No definitions found" for French #173

Closed llbaker302 closed 2 months ago

llbaker302 commented 2 months ago

Describe the bug No matter which word is selected, the Wikitionary Dictionary (English) for French will always return "No definitions Found"

To Reproduce Steps to reproduce the behavior:

  1. Install vocabsieve on Windows
  2. Set Target Language to French
  3. Drag Wikitionary (English) to Dictionary Group 1
  4. Import a sample phrase from clip board
  5. Double click any word

Expected behavior A definition of the word appears from Wikitionary

Screenshots image

Logs VocabSieve version: 0.12.0 Python version: 3.11.8 (tags/v3.11.8:db85d51, Feb 6 2024, 22:03:32) [MSC v.1937 64 bit (AMD64)] on Windows 10 AMD64 PyQt5 (Qt bindings) version: 5.15.10, Qt 5.15.2

2024-09-03 21:53:16.816 | DEBUG | vocabsieve.main:initSources:148 - Initializing sources 2024-09-03 21:53:16.816 | DEBUG | vocabsieve.main:initSources:154 - Source Group 1: ['Wiktionary (English)'] has been created. 2024-09-03 21:53:16.816 | DEBUG | vocabsieve.main:initSources:161 - Source Group 2: ['Google Translate'] has been created. 2024-09-03 21:53:16.818 | DEBUG | vocabsieve.main:initSources:173 - Audio source group: ['Forvo'] has been created 2024-09-03 21:53:16.818 | DEBUG | vocabsieve.main:initTimers:1049 - Initializing timers 2024-09-03 21:53:16.848 | DEBUG | vocabsieve.main:getKnownDataOnThread:426 - Some data sources aren't available, not getting known data now 2024-09-03 21:53:29.387 | DEBUG | vocabsieve.ui.searchable_boldable_text_edit:bold:11 - bolding lendemain, 2024-09-03 21:53:29.390 | DEBUG | vocabsieve.ui.multi_definition_widget:lookup:135 - Looking up lendemain in [<vocabsieve.sources.wiktionary_source.WiktionarySource object at 0x0000018FC79B2CD0>] 2024-09-03 21:53:29.390 | DEBUG | vocabsieve.ui.multi_definition_widget:lookup:135 - Looking up lendemain in [<vocabsieve.sources.google_translate_source.GoogleTranslateSource object at 0x0000018FC79B3BD0>] 2024-09-03 21:53:29.390 | INFO | vocabsieve.sources.wiktionary_source:_lookup:20 - Looking up lendemain in Wiktionary 2024-09-03 21:53:29.391 | INFO | vocabsieve.sources.forvo_audio_source:_lookup:173 - Forvo lookup lendemain 2024-09-03 21:53:29.805 | ERROR | vocabsieve.sources.wiktionary_source:_lookup:26 - Failed to get data from Wiktionary: HTTPError('404 Client Error: Not Found for url: https://kaikki.org/dictionary/French/meaning/l/le/lendemain.json') 2024-09-03 21:53:29.806 | INFO | vocabsieve.sources.wiktionary_source:_lookup:20 - Looking up lendemain in Wiktionary 2024-09-03 21:53:29.884 | DEBUG | vocabsieve.ui.multi_definition_widget:run:70 - LookupWorker: looked up lendemain in Google Translate in 0.49 seconds 2024-09-03 21:53:29.885 | DEBUG | vocabsieve.ui.multi_definition_widget:appendDefinition:164 - All sources have been looked up 2024-09-03 21:53:30.111 | ERROR | vocabsieve.sources.wiktionary_source:_lookup:26 - Failed to get data from Wiktionary: HTTPError('404 Client Error: Not Found for url: https://kaikki.org/dictionary/French/meaning/l/le/lendemain.json') 2024-09-03 21:53:30.112 | DEBUG | vocabsieve.ui.multi_definition_widget:run:70 - LookupWorker: looked up lendemain in Wiktionary (English) in 0.72 seconds 2024-09-03 21:53:30.112 | DEBUG | vocabsieve.ui.multi_definition_widget:appendDefinition:164 - All sources have been looked up

Desktop (please complete the following information):

1over137 commented 2 months ago

Should be fixed in 0.12.1

llbaker302 commented 2 months ago

Can confirm this is fixed in 0.12.1!