gpg fails to use next keyserver with FAILURE response

[Stevehans]

FreePBX Version

FreePBX 17

Issue Description

The required keys were not on the first keyserver attempted, but the return didn't match that expected in code "[GNUPG:] NODATA 1", so the key that had not been received was then validated, which failed.

The checks in GPG.class.php/getKey() need to be extended to check for FAILURE as well as NODATA, and potentially the status return?

Operating Environment

17.0.15.27

Relevant log output

[2024-06-20 09:17:26] [freepbx.INFO]: key result: array (   
    'stdout' => '',   
    'stderr' => 'gpg: keyserver receive failed: No data ',   
    'status' =>    array (     0 => '[GNUPG:] FAILURE recv-keys 167772218',   ),   'exitcode' => 2, )

[Stevehans]

gpg (GnuPG) 2.2.40 libgcrypt 1.10.1

[Stevehans]

This seems related to the 2.2 version that is installed as part of the 17 setup, the 2.0 on FreePBX 16 is fine. Just pulling the gpg source so I can see what the error code means

[kguptasangoma]

Hi @Stevehans can you please modify the if condition to add below OR condition as well then let me know if this works for you ? if ((strpos($retarr['status'][0], "[GNUPG:] FAILURE recv-keys") === 0) || ($retarr['status'][0] == "[GNUPG:] NODATA 1")) {

thanks

[Stevehans]

I've done that already on my copy and it's fine. Just checking, looks as though the issue is that 2.2 now uses dirmngr that is returning this status

[kguptasangoma]

okay thanks so i will push this fix which will work for older version of GPG or new too.

[Stevehans]

Perfect, thanks

[kguptasangoma]

framework v17.0.15.28