Converting UTF-8 result to UTF-8

[edrobal]

Superfecta convert to UTF-8 an UTF-8 result. Example: Executing LocalTel CH Searching Local.ch... 'JV Jura Voyages Sàrl' result took 0.0661 seconds. Text is good. Converting result to UTF-8 This scheme would set the caller id to: JV Jura Voyages S?rl Text is no more good.

[rodrigoscoelho]

Same problem here. Please fix it...

[chriszuercher]

I had a similar issue but with Cache and local.ch module. For me moving to UTF8 conversion more upwards in code helped and it works. See my Pull request here: https://github.com/POSSA/Caller-ID-Superfecta/pull/284 it was so far not integrated in the code so you need to apply it by yourself.

[edrobal]

Hello

I think that the best is to add an option for converting or not the result for each module or to define if the result is UTF8.

Regards.

Le 14. 10. 16 à 10:49, chriszuercher a écrit :

I had a similar issue but with Cache and local.ch module. For me moving to UTF8 conversion more upwards in code helped and it works. See my Pull request here: #284 https://github.com/POSSA/Caller-ID-Superfecta/pull/284 it was so far not integrated in the code so you need to apply it by yourself.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/POSSA/Caller-ID-Superfecta/issues/290#issuecomment-253744105, or mute the thread

Christian Laborde

GTS - Informatique Une division de GTS Global Travel Services SA

+41 21 799 54 57

Place de la Gare 4 CH 1096 Cully Suisse

[edrobal]

is there a pilot in the plane ?????

[rodrigoscoelho]

I don't know about a pilot, but at least there is passenger on it..

Email enviado usando um celular....

Em 17 de nov de 2016 07:50, "Christian Laborde" notifications@github.com escreveu:

is there a pilot in the plane ?????

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/POSSA/Caller-ID-Superfecta/issues/290#issuecomment-261202194, or mute the thread https://github.com/notifications/unsubscribe-auth/AGl5mrYI082dcDKnRxN0_hlLfWAyB2xnks5q_CNsgaJpZM4JQu-C .

[edrobal]

Why is this issue closed ? This error is always existing.

[code-chicken]

I am also still having this error. Especially the data from Google Contacts is in UTF8 by default, so converting the data again doesn't make sense. For testing I disabled all modules except Google Contacts and still got names with broken umlauts.

[clst]

In my FreePBX the pull request referenced above was merged already. But the $superfecta->stripAccents function seems to munge all accented characters to some uppercase non-accented version.
I commented out that line with no adverse effects so far: $callerid = $superfecta->stripAccents($callerid);

I do not recommend anyone doing that without looking into it first. I might have possibly broken something by doing that.

[edrobal]

Yes I solve also my problem when I commented the same line. But I need also to comment _utf8_decode on superfecta_single because local.ch respond in utf8 and superfecta convert badly in this case. And evidently I must avoid any superfecta upgrade.

[clst]

You might also get more trouble because substr in this line: $callerid = substr($callerid, 0, 40); does not care about multi byte characters and will sometimes break the whole string.

I don't have a proper fix yet, because my custom http CID Lookup will sometime interfere with Superfecta.