search

FreePBX / ucp

Module of FreePBX (User Control Panel) :: The user control panel is a way for users to control call handling and personal settings from a web browser.
http://www.freepbx.org
GNU Affero General Public License v3.0
4 stars 18 forks source link

originate in user and device mode #4

Closed wizhippo closed 8 years ago

wizhippo commented 8 years ago

Originate using the correct extension for originate when in user and device mode.

tm1000 commented 8 years ago

You get $data but then you never use $data again

wizhippo commented 8 years ago

Data is just used to make sure an device exists before we try to originate to the user. We could blindly send it the 'from'. To be honest I'm not sure why the check for the device in the first place.

tm1000 commented 8 years ago

It's used to prevent callerid spoofing. However it could probably be checked by just checking what the default extension is of the user from usermanager

wizhippo commented 8 years ago

@tm1000 thanks for the clarification and direction. Is this better?

tm1000 commented 8 years ago

Yes that is perfect! thanks!