FreeUKGen / FreeBMD2

For everything related to FreeBMD2. An updated version of the original FreeBMD genealogy website.
Apache License 2.0
1 stars 0 forks source link

Make CSV download and printable format limited to 50 results. #423

Open DeniseColbert opened 3 years ago

DeniseColbert commented 3 years ago

Decision: change text on button and add a sentence to the printable page:

To print these results, or download as PDF, right-click and select "Print..." or CTRL+P (browser-dependent)

Captainkirkdawson commented 3 years ago

There needs to be more thought on this. The abilities are totally browser dependant While right click p or ctrl, shift p may well enable printing for most browsers, the ability to reformat as PDF or to save as nicely formatted text is rare. The right click save will save as an html file on your computer, it can only be viewed in a browser. So the suggestion on download is quite misleading which is why we provide the download as csv sometimes

PatReynolds commented 2 years ago

See also #422

DeniseColbert commented 2 years ago

I think it's pretty universal now that browser Print... function allows PDF download:

Screenshot (20)

Perhaps this needs testing on various browsers? I tested Chrome, Edge and Firefox. The former two browsers offer the Print function on right-click, the latter via the browser hamburger menu.

We would need to update the Help, perhaps with some general guidance.

DeniseColbert commented 2 years ago

@Vino-S to test on Safari, @PatReynolds to test on DuckDuckGo and Komodo

Vino-S commented 2 years ago

Ready for testing in test3

DeniseColbert commented 2 years ago

Thanks Vino :)

You can print these results or download to PDF using your right-click or browser menu.

Could this be added to the Results page, perhaps where indicated below?

image

AlOneill commented 2 years ago

@DeniseColbert how does a keyboard-only user right-click? And what is meant by "browser menu"?

AlOneill commented 2 years ago

@DeniseColbert I've done some reading and testing and can say that, to cut a long story short, right-clicking by keyboard alone on a Mac is impractical. I cannot test on Windows.

Who wants their results saved as a PDF file? I did manage to save the page using the keyboard only, as text without the HTML, but it was a right palaver and the file would need a lot of editing to be useful to a researcher.

I agree with @Captainkirkdawson that a button to download a CSV file would be so much more convenient.

@Vino-S in the listing, there is a space missing between the District name and the opening bracket.

DeniseColbert commented 2 years ago

Thanks, @AlOneill. We already have the Download CSV option, so perhaps that's enough and we can remove this altogether? Although I think it's fair to say that lots of our users won't have a clue what CSV is...

I find saving PDFs a Good Thing in my research. It helps me to keep digital records without printing pages of info, but allows me to do so if I want to.

AlOneill commented 2 years ago

@DeniseColbert Oops, missed that! Mea culpa.

However, there is an issue. I can open the "Tools" drop-down with "Space", but I cannot select any of the options — I would expect to use the arrow keys to move between the choices.

AlOneill commented 2 years ago

@DeniseColbert Trying again, I find that "Tab" and shift-tab takes one through the choices. This is not the expected behaviour and will need explaining for our users.

AlOneill commented 2 years ago

@Vino-S @DeniseColbert The WebAim site has a listing of expected keyboard-only navigation: https://webaim.org/techniques/keyboard/#testing

richpomfret commented 2 years ago

Update - @Vino-S currently looking to see if this is possible.

Vino-S commented 2 years ago

Ready for testing in test3

PatReynolds commented 2 years ago

@DeniseColbert

DeniseColbert commented 2 years ago

I can't see changes in Test 3

It's still 'Printable Format' in the Tools menu:

image

And there's nothing about Printing on the resulting page:

image

richpomfret commented 2 years ago

@Vino-S can you check this again? Denise could not find the updates you mentioned.

PatReynolds commented 2 years ago

Leave as 'printable format' but have a question in initial testing.

Consistency with FreeCEN/FreeREG needed.

DeniseColbert commented 2 years ago

Leave as printable format for now but add text to printable page.

DeniseColbert commented 1 year ago

https://github.com/FreeUKGen/FreeBMD2/issues/423#issuecomment-1020337555

This does need adding to REG and CEN also

DeniseColbert commented 1 year ago

Decision: add another option to dropdown: Download as PDF

KristinaGadzhieva commented 7 months ago

Amir, please have a look at Tools menu

richardofsussex commented 6 months ago

I've restored the list of results in the Print friendly version (required an explicit @timeout = false in the controller), amended the wording as requested and tweaked the format of the listing: image

richardofsussex commented 6 months ago

Note that the request to change the menu item to "Download/print" has been cancelled (twice) in the comments above. That's why it hasn't changed!

richardofsussex commented 6 months ago

Set a limit of 50 for both printable format and CSV download.

Vino-S commented 6 months ago

Ready for testing in test3

KristinaGadzhieva commented 6 months ago

Doesn't work in printable format. @Vino-S please have a look

KristinaGadzhieva commented 5 months ago

when the number of results is more than 50, the print button can be hiden

DeniseColbert commented 3 months ago

Use of Print dialogue box means that the browser will print everything on screen, so Vino has removed the Print/Download buttons from search results pages with more than 50 records.

@Vino-S to explore how we can tell people that we allow a max of 50 records to be downloaded

KristinaGadzhieva commented 2 months ago

To check on Beta.

richardofsussex commented 2 months ago

I had a note to check the GEDCOM download. I find that it works as per the spec - if 100 records at a time are displayed, it will only download the first 50. However I don't see any text or message advising me that I haven't got all 100 records in my download.

richardofsussex commented 1 month ago

@Vino-S please implement this