Open SteveBiggs opened 1 year ago
I won't get involved in coding FreeREG, but the relevant value (_YEARMIN) is set in /lib/freereg_validations.rb. Presumably we need a minimum year for validation purposes: so what should it be, @SteveBiggs?
I seem to remember that we could enter even earlier than 1000. The problem was a leading zero. But it could have been in FR1. Is it possibke to edit the entry after uploading without validation?
In what context do you hit this limit? When entering actual records? From an examination of the (Rails) code, YEAR_MIN is primarily used as a start point when calculating numbers for places, churches and registers.
This cropped up a long time ago, when someone wanted to upload records with pre 1000 dates ( ie with 3 digit year dates).
I seem to remember that it was decided to put a leading zero in front of the record year and that was done. So the question is: who has back tracked and remove the leading zero?
Eric Booker
On 27 Oct 2022, at 09:51, Richard Light @.***> wrote:
In what context do you hit this limit? When entering actual records? From an examination of the (Rails) code, YEAR_MIN is primarily used as a start point when calculating numbers for places, churches and registers.
— Reply to this email directly, view it on GitHub https://github.com/FreeUKGen/MyopicVicar/issues/2609#issuecomment-1293202005, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACHPJAEKMMTKIJNNDEORVVTWFI7CJANCNFSM6AAAAAARPLKRD4. You are receiving this because you are subscribed to this thread.
Ideally, there would be no limit to the year but we certainly need to be able to go pre-1000. Maybe 0000 should be the limit (however, there are known records of births of Kings, etc. even BC!) I don't know why 1300 was chosen as a lower limit.
I tried editing a record on FreeREG and it does not allow any date before 1300.
indeed, Stephen.
I have a chart of English Kings which starts pre 410 with the Roman governors. Then c500 with King Arthur and so on with 18 kings before it gets to 122-1307 for Edward 2nd.
Eric B
On 27 Oct 2022, at 11:51, Stephen Biggs @.***> wrote:
Ideally, there would be no limit to the year but we certainly need to be able to go pre-1000. Maybe 0000 should be the limit (however, there are known records of births of Kings, etc. even BC!) I don't know why 1300 was chosen as a lower limit.
I tried editing a record on FreeREG and it does not allow any date before 1300.
— Reply to this email directly, view it on GitHub https://github.com/FreeUKGen/MyopicVicar/issues/2609#issuecomment-1293344910, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACHPJAFQTMGIZI3VLNX2IDDWFJNEZANCNFSM6AAAAAARPLKRD4. You are receiving this because you commented.
@Captainkirkdawson do you have any ideas on this?
The earliest year that FreeREG will accept in a transcription is 1300. There are records that give earlier years so we should be able to enter them.