search

Freed-Wu / tree-sitter-tmux

🌲👨 tmux grammar for tree-sitter
10 stars 1 forks source link

Fix/ add set window option directive to grammer #4

Closed jeremiah-snee-openx closed 8 months ago

jeremiah-snee-openx commented 8 months ago

Resolves #3

Adds set-window-option with setw to grammar regenerate bindings

update test

Summary by CodeRabbit

coderabbitai[bot] commented 8 months ago

Walkthrough

The project introduces extensive updates, focusing on integrating and refining the Tree-sitter language parser for tmux configuration files. Changes span across various bindings (C, Go, Node.js, Python, Rust, and Swift), build configurations, and the grammar logic itself, notably including the handling of set-window-option directives. This collective effort enhances compatibility, standardizes coding styles, and extends support across different programming languages and platforms, ensuring a more robust and accessible tool for developers.

Changes

Files Change Summary
.editorconfig, .gitattributes Introduced coding style rules and LF line endings; marked certain files as linguist-generated.
Makefile, Package.swift Updated build configurations and dependencies for tree-sitter-tmux project.
binding.gyp Updated dependencies and set C standard to c11 for tree_sitter_tmux_binding.
bindings/.../tree-sitter-tmux.h, .../tmux.h Defined interfaces for the Tree-sitter tmux parser across various language bindings.
bindings/.../binding.*, index.*, lib.rs Refactored and introduced functionality for interacting with the tmux grammar in multiple languages.
grammar.js Added handling for set-window-option directives.
src/tree_sitter/... Enhanced memory allocation, dynamic array management, and parser functionality in Tree-sitter.

Assessment against linked issues

Objective Addressed Explanation
Add set-window-option/setw to grammar (#3) ✅

Poem

🐰🎉

In the realm of code, where parsers dwell,
A rabbit hopped, casting a spell.
Tmux configs parsed, with ease and cheer,
Bringing developers, far and near.
Through files and bindings, the magic spread,
As the rabbit's work, ahead it led.
🌟 "To better tools," it whispered, bright,
"We hop together, into the light."

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.
Freed-Wu commented 8 months ago

Can you split this PR to many independent PRs? It looks only first commit is related to #3

jeremiah-snee-openx commented 8 months ago

Can you split this PR to many independent PRs? It looks only first commit is related to #3

Sure thing. Here is the PR with changes unrelated to #3 .

This PR has additional changes from tree-sitter cli generate command adding/ modifying files. This PR also had some commits to resolve PR Checkers.

jeremiah-snee-openx commented 8 months ago

@Freed-Wu Need to merge #7 first. Then I can resolve conflicts and reduce this PR to just fixing #3