Freemius / wordpress-sdk

https://freemius.com
GNU General Public License v3.0
267 stars 77 forks source link

Polylang conflict #421

Open Stibo opened 4 years ago

Stibo commented 4 years ago

🐞 bug report

Behavior:

options.data = '<?php echo $str; // phpcs:ignore WordPress.Security.EscapeOutput ?>&'+options.data;

As you can see, there are php opening and closing tags in a string, that will be outputted by Polylang later. I think this php tags in string will somehow break this code after its being processed by the Freemius SDK.

I hope this input helps to fix this problem, its really ugly to see pll_ajax_backend=1& on this pages.

Versions: (*)

Stibo commented 4 years ago

This is still an issue with the current version. Any response from you guys would be appreciated!

Stibo commented 3 years ago

Do you guy even read the issues on GitHub? This is still an issue.

vovafeldman commented 3 years ago

Hi @Stibo and thanks for your report! Sorry for not commenting earlier, we are definitely reviewing issues on GitHub. This never got prioritized as you are the only one who raised the issue in over 5 years, and we never saw it happening with any other plugins setup. I wish we could do everything, but we have to prioritize our resources. Regardless, if you already have the environment in place it would be great if you could upload a screenshot of the issue so we'll have it recorded for when we get to it.

Stibo commented 3 years ago

Hi, thanks for the answer. It actually happens on every page that has the plugin "Polylang" installed.