search

FreezingMoon / AncientBeast

The Turn Based Strategy Game/eSport. Master your beasts! 🐺
https://AncientBeast.com
GNU Affero General Public License v3.0
1.69k stars 589 forks source link

[Feature] Added bounce animation on skip button #2593

Closed prateeksingh19 closed 3 months ago

prateeksingh19 commented 3 months ago

This fixes issue #2535 added bounce animation on skip button only when unit is out of actions and not when skip button is clicked manually.

Added animations in styles file for skip bounce button. Attached bounce class to the skip button when the unit is out of actions. Removed the bounce class from the skip button after 3s using setTImeout.

My wallet address is 0x252b0dB01b57eC7A4A02c05cc06A0529d43C7142

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ancientbeast ✅ Ready (Inspect) Visit Preview Aug 8, 2024 3:23pm
DreadKnight commented 3 months ago

@prateeksingh19 I see no bounce at all...

prateeksingh19 commented 3 months ago

@prateeksingh19 I see no bounce at all...

that's strange, i can see it in mine, i just checked it rn.

DreadKnight commented 3 months ago

@prateeksingh19 Retested. Bounce only happens once when I click on unit itself and turn gets skipped. I take it you didn't read properly the issue once again 🐻 The whole bouncing should be happening the whole time when there are no more actions left.

DreadKnight commented 3 months ago

@prateeksingh19 Pretty good now. One more little thing needed: the animation shouldn't loop anymore while the button is being hovered.

prateeksingh19 commented 3 months ago

Ok, Will do. Thanks for the review.

DreadKnight commented 3 months ago

@prateeksingh19 Alrighty. Patched it myself as well a bit, was hoping to make the button's animation sort of finish by itself on hover and then stop instead of snapping back into place, but didn't work as expected, oh well...

Will merge and send bounty in a bit.

DreadKnight commented 3 months ago

@prateeksingh19 Bounty sent with bonus -> https://www.mintme.com/explorer/tx/0x86bca1cab11b8bd55851329608fc3260535eb24d85d4543fa26c05aabd6c610c 🪙

prateeksingh19 commented 3 months ago

Thanks. Enjoyed working with you.

DreadKnight commented 3 months ago

Thanks. Enjoyed working with you.

Cool! 👍🏻 Every little patch helps out in the grand image. Hopefully will see more PRs from you as well. Feel free to poke at related issue -> https://github.com/FreezingMoon/AncientBeast/issues/1976